microsoft / microsoft/vasim

Remove code duplication via refactoring SimulatedInMemory*ClusterStateProvider files

Open
#126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted refactor TODO
Dominant language
Python
Stars
12
Forks
11
Avg merge
7d 23h
Merged PRs (30d)
3

Description

We have code duplication in
SimulatedInMemoryPredictiveClusterStateProvider and SimulatedInMemoryClusterStateProvider

Need to check order and refactor so code is reused via base methods

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare SimulatedInMemoryPredictiveClusterStateProvider and SimulatedInMemoryClusterStateProvider, paying attention to method order and the existing base methods. Identify the duplicated behavior and determine which parts can be reused through the base class. Done means the duplicated code is removed while both providers retain the required ordering and behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.