nit: should we rename `destination_ipv4_address` and `destination_port` to a more accurate name, like local_ip and remote_ip?
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105
- Forks
- 34
- Avg merge
- 3d 39m
- Merged PRs (30d)
- 5
Description
nit: should we rename destination_ipv4_address and destination_port to a more accurate name, like local_ip and remote_ip?
Originally posted by @saxena-anurag in https://github.com/microsoft/usersim/pull/306#discussion_r3278857565
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked discussion in pull request 306, then locate the uses of destination_ipv4_address and destination_port in the repository. Confirm the intended terminology with maintainers before changing names, and consider the work complete when the agreed names and all references are updated consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100