microsoft / microsoft/typespec

[Bug]: Versioning missing added after removed scenario

Open
#7,035 0 comments 0 reactions 0 assignees View on GitHub
bug lib:versioning triaged:core
Dominant language
Java
Stars
5.9k
Forks
394
Avg merge
1d 23h
Merged PRs (30d)
104

Description

### Describe the bug

When a model property is added after a model was removed the error reported is incorrect:
`'DemoService.Bar' was added in version 'v1' but contains type 'DemoService.Bar.foo' added in version 'v3'.`

Currently, we don't have "added after removed" check. We are having this error reported because the model is no longer available (so it assumes it hasn't been added/ever existed) the message is pretty confusing because in reality the model was removed, we need to add a check for added after removed to the versioning checks and fix this error incorrectly showing up.

### Reproduction

[minimal reproduction](https://typespec.io/playground/?c=aW1wb3J0ICJAdHlwZXNwZWMvaHR0cCI7CtIZcmVzdNUZdmVyc2lvbmluZyI7Cgp1c2luZyBWyRQ7CgpAxyJlZCjHGHMpCkBzZXJ2aWNlKCN7IHRpdGxlOiAiV2lkZ2V0IFPGGiIgfSkKbmFtZXNwYWNlIERlbW%2FHGjsKCmVudW3IZnMgewogIHYxLMQGMsUGMwp96ACLSHR0cDvHDFJlc3Q7CiBAcmVtb3brAI8udjIpCiAgbW9kZWwgQmFyxVEgIEBhZGTNJjMpIMUZZm9vOiBzdHLlAOB9&e=%40typespec%2Fopenapi3&options=%7B%22linterRuleSet%22%3A%7B%22extends%22%3A%5B%22%40typespec%2Fhttp%2Fall%22%5D%7D%7D)

### Checklist

- [x] Follow our [Code of Conduct](https://github.com/microsoft/typespec/blob/main/CODE_OF_CONDUCT.md)
- [x] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
- [x] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/Microsoft/typespec/discussions).
- [x] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.