microsoft / microsoft/typescript-benchmarking

Retry nodejs.org and other fetches

Open
#77 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
26
Forks
6
Avg merge
7m
Merged PRs (30d)
2

Description

[18:38:45.539] [0] $ node /home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/bin/ts-perf host install --host 'node@18.15.0'
Error: Could not download 'https://nodejs.org/download/release/index.json'; 502 Bad Gateway
    at getReleases (/home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/packages/commands/src/host/nodeInstaller.ts:53:29)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at installMatchingNodeHosts (/home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/packages/commands/src/host/nodeInstaller.ts:290:22)
    at installHost (/home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/packages/commands/src/host/install.ts:15:26)
    at Command._invokeExec (/home/azdo/agent/_work/2/typescript-benchmarking/node_modules/.pnpm/power-options@0.3.4/node_modules/power-options/dist/lib/resolver.js:978:17)
    at Command.execute (/home/azdo/agent/_work/2/typescript-benchmarking/node_modules/.pnpm/power-options@0.3.4/node_modules/power-options/dist/lib/resolver.js:869:13)
    at CommandLine.execute (/home/azdo/agent/_work/2/typescript-benchmarking/node_modules/.pnpm/power-options@0.3.4/node_modules/power-options/dist/lib/commandLine.js:63:17)
    at CommandLine.parseAndExecute (/home/azdo/agent/_work/2/typescript-benchmarking/node_modules/.pnpm/power-options@0.3.4/node_modules/power-options/dist/lib/commandLine.js:76:9)
    at main (/home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/packages/cli/src/index.ts:69:24)
[18:38:46.242] [0] ✘ Command failed with exit code 1: node /home/azdo/agent/_work/2/typescript-benchmarking/ts-perf/bin/ts-perf host install --host 'node@18.15.0'
[18:38:46.242] [0] ✘ (done in 703ms)
file:///home/azdo/agent/_work/2/typescript-benchmarking/node_modules/.pnpm/execa@9.2.0/node_modules/execa/lib/return/final-error.js:6
	return new ErrorClass(message, options);
	       ^

We should retry 500 errors at least once after a delay.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in packages/commands/src/host/nodeInstaller.ts, especially getReleases and the fetches shown in the stack trace. Trace the related host-install command and identify the other fetches covered by the request. Done means 500-level failures retry at least once after a delay instead of failing immediately.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
cli, networking
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.