microsoft / microsoft/typescript-analyze-trace
State machine incorrectly treats division as the start of a regex
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 429
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
e.g. in x / y, / y will be classified as a regex (to EOL).
To handle this properly, we'd need a parser - you need to know whether the slash is at the start of an expression. Offsets in the incorrectly classified region will (probably) map to the correct line but an incorrect character position, since trivia skipping rules are different within regexes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the state machine that classifies slash-delimited regions, then reproduce the x / y case and compare it with a genuine regex; done means division is not classified as a regex and offsets remain correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100