microsoft / microsoft/tyger

Tags are not validated when updating buffers/runs

Open
#207 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
74
Forks
23
Avg merge
6d 16h
Merged PRs (30d)
7

Description

When creating a new buffer or run, the user-supplied tags are validated by the server.
When using tyger {buffer,run} set <id> --tag ..., the tags are not validated.

Example:

$ tyger buffer create --tag a@=b
Error: InvalidInput: Tag keys must contain up to 128 letters (a-z, A-Z), numbers (0-9) and underscores (_)

$ tyger buffer create
2ui2lm6hwrxexoxuwnosd6l3me

$ tyger buffer set 2ui2lm6hwrxexoxuwnosd6l3me --tag a@=b
{
  "id": "2ui2lm6hwrxexoxuwnosd6l3me",
  "createdAt": "2025-04-09T14:32:51.357197Z",
  "location": "westus2",
  "tags": {
    "a@": "b"
  },
  "eTag": "17471511304344921275"
}

Question: Should they also be validated when they are used for filtering multiple buffers/runs, e.g. for tyger buffer list --tag a@=b$?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the implementations of tyger buffer set, tyger run set, and the corresponding create commands to find where tags are validated. Reproduce the invalid-tag example, then inspect the list filtering path to determine whether the same validation applies there; done means update behavior is consistent with creation and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.