microsoft / microsoft/tolerant-php-parser

New release request

Open
#420 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
894
Forks
85
Avg merge
2d 13h
Merged PRs (30d)
3

Description

https://github.com/microsoft/tolerant-php-parser/releases/tag/v0.1.2 (latest available release) generates few deprecation messages running on PHP 8.4:

Deprecated: Microsoft\PhpParser\Parser::parseSourceFile(): Implicitly marking parameter $uri as nullable is deprecated, the explicit nullable type must be used instead in /XXX/microsoft/tolerant-php-parser/src/Parser.php on line 177
Deprecated: Microsoft\PhpParser\Token::getText(): Implicitly marking parameter $document as nullable is deprecated, the explicit nullable type must be used instead in /XXX/microsoft/tolerant-php-parser/src/Token.php on line 45
Deprecated: Microsoft\PhpParser\Node::getDescendantNodesAndTokens(): Implicitly marking parameter $shouldDescendIntoChildrenFn as nullable is deprecated, the explicit nullable type must be used instead in /XXX/microsoft/tolerant-php-parser/src/Node.php on line 152
...

That seems to have been fixed in https://github.com/microsoft/tolerant-php-parser/pull/410.

@roblourens is it please possible to get a new release that includes the fix, so no deprecation messages are shown for 8.4?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the v0.1.2 release page and pull request #410 first to confirm the PHP 8.4 compatibility fix is included. Check the project's release process, then publish a new release containing that fix. Done means the release is available and PHP 8.4 no longer emits the reported deprecation messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
compilers, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.