microsoft / microsoft/tolerant-php-parser
Clean up usages of `iterator_to_array`
Open
Nobody has claimed this yet.
continuous-improvement
performance
up-for-grabs
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
We are using iterator_to_array during some tree traversals, which is good tell-tale sign that those operations could be further optimized so we don't have to duplicate every element in memory.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the iterator_to_array usages involved in tree traversals and inspect how each traversal consumes its results. Done means those traversals no longer duplicate every element in memory while preserving their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100