microsoft / microsoft/tolerant-php-parser
Parser does not detect invalid cast expressions
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
Cast expressions may not contain anything except spaces and tabs between the parentheses.
In the following example, the parser generates a CastExpression while PHP sees it as a constant named 'int' followed by a variable.
Example:
<?php (/* hello */int)$a;
Actual result:
No error.
Expected result:
syntax error, unexpected $a (T_VARIABLE)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no file or test; begin by reproducing the PHP example and locating the parser entry point for cast expressions. Add a regression test covering comments between the parentheses, and confirm the parser reports the unexpected variable rather than creating a CastExpression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100