microsoft / microsoft/tolerant-php-parser
testing: skipped.json should indicate the directory of the test case that is skipped
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
One way to fix this would be to have tests/cases/grammar/skipped.json and tests/cases/lexical/skipped.json, and have the corresponding test cases load the corresponding skipped files.
Example: tests/skipped.json currently contains stringLiteral16.php. This skips tests/cases/lexical/stringLiteral16.php.
However, if a developer were to add tests/cases/grammar/stringLiteral16.php, that would also be unintentionally skipped right now, which would be surprising.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading tests/skipped.json and the test-case loading paths under tests/cases/grammar and tests/cases/lexical. Update the skipped-test handling so skip entries are scoped to their test-case directory, then verify that a skipped lexical case does not also skip a grammar case with the same filename.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100