microsoft / microsoft/tolerant-php-parser
Can't parse names that are reserved words
Open
Nobody has claimed this yet.
bug
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
https://github.com/felixfbecker/php-language-server/issues/448
A namespace named object is ok, even though it's a reserved word: http://php.net/manual/en/reserved.other-reserved-words.php
It's a "soft reserved" word - but it even seems that reserved words like 'int' are ok as names in PHP?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the namespace examples from the issue, including names such as object and int, and compare the parser's behavior with PHP's reserved-word rules. Done means valid soft-reserved names are parsed successfully, with coverage for the reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100