microsoft / microsoft/tolerant-php-parser
TextEdit.applyEdits shouldn't use assert
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
I think the assert for "Supplied TextEdit[] must not overlap, and be in increasing start position order." should be an exception.
From #158
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate TextEdit.applyEdits in the PHP sources and inspect the assertion for overlapping or out-of-order edits. The change is complete when invalid TextEdit[] input produces an exception instead of relying on an assertion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100