microsoft / microsoft/tolerant-php-parser
ForeachStatement->foreachKey with an key in the statement returns `$key =>`
Open
Nobody has claimed this yet.
bug
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
See:
Test script:
<?php
use Microsoft\PhpParser\Parser;
require_once './vendor/autoload.php';
$parser = new Parser;
$ast = $parser->parseSourceFile(file_get_contents('source.php'));
var_dump($ast->statementList[1]);
exit;
Source.php:
<?php
foreach ([0, 1, 2, 3, 4] as $array => $index) {
echo $array;
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the Parser parseSourceFile example against source.php and inspect the resulting foreach statement AST. Trace how the parser handles the as $array => $index form, then verify that the AST represents the key and value separately and add a regression test for this input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100