microsoft / microsoft/tolerant-php-parser
Messy usage of static property access
Open
Nobody has claimed this yet.
discuss
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
I saw a lot of messy access to static properties in the code base, i.e. static properties are accessed on the instance with -> or on the instance with :: instead of on the class with ::
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the codebase for static properties accessed with -> or :: on an instance, then inspect each usage in context. Confirm which accesses are incorrect and whether existing tests cover them. Done means the inconsistent access patterns are corrected without changing parser behavior, with relevant tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers, devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100