microsoft / microsoft/tolerant-php-parser

Thorough code review to ensure we didn't miss anything from the spec

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

grammar up-for-grabs
Dominant language
PHP
Stars
894
Forks
85
Avg merge
2d 13h
Merged PRs (30d)
3

Description

The PHP spec was a bit open to interpretation at times, so it'll be good to have a second pass, and should be a good opportunity to add more tests.

While we're doing this pass, we should submit any remaining PRs to the PHP language spec based on our findings from this project. Already submitted a few PRs, and I've been meaning to submit some more.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the parser's current behavior and tests against the PHP language specification. Review the findings from the already submitted specification PRs, then identify any uncovered cases and add tests for them. Done means the review is complete, coverage gaps are addressed, and any remaining PHP-spec PRs have been submitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
compilers, testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.