microsoft / microsoft/tolerant-php-parser
Make error-handling more testable
Open
Nobody has claimed this yet.
continuous-improvement
discuss
error-handling
- Dominant language
- PHP
- Stars
- 894
- Forks
- 85
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 3
Description
e.g. right now we test that skipped/missing tokens are properly included in the tree, but we have no tests for the post-parse getDiagnostics walk.
Thoughts?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing tests for skipped or missing tokens and the post-parse getDiagnostics walk. Trace how diagnostics are collected after parsing, then add coverage for that path and confirm the tests verify the expected diagnostics without relying only on tree contents.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- compilers, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100