[MTP][Breaking] Don't set `IsTestingPlatformApplication` at all by MTP
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1k
- Forks
- 312
- Avg merge
- 8h 30m
- Merged PRs (30d)
- 469
Description
We should consider https://github.com/microsoft/testfx/pull/7566 as a breaking change.
One additional benefit here is, because MTP itself won't set a default, test frameworks will have the ability to not touch the property at all if it has a value, which means it's user specified value. This is a problem today for at NUnit/MSTest because we always overwrite `IsTestingPlatformApplication`, and only letting `EnableNUnitRunner` and `EnableMSTestRunner` control it. So users cannot set it in csproj at all which was causing confusion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request 7566 and tracing where Microsoft.Testing.Platform sets IsTestingPlatformApplication. Compare that behavior with the NUnit and MSTest runner settings described in the issue. Done means MTP leaves the property untouched by default so a value supplied in the user's csproj is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100