microsoft / microsoft/testfx

MSTest attributes should be sealed in most cases.

Open
#7,374 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/mstest type/breaking-change
Dominant language
C#
Stars
1k
Forks
312
Avg merge
8h 30m
Merged PRs (30d)
469

Description

There is no point in inheriting many of the MSTest attributes and they should be made sealed.

- `DiscoverInternalsAttribute`
- `DoNotParallelizeAttribute`
- `ParallelizeAttribute`
- `TestDataSourceDiscoveryAttribute`
- `WinUITestTargetAttribute`
- `STATestClassAttribute`
- `DataRowAttribute`
- `DataTestMethodAttribute` (attribute should be removed altogether)
- `UITestMethodAttribute` (maybe?)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the declarations for DiscoverInternalsAttribute, DoNotParallelizeAttribute, ParallelizeAttribute, TestDataSourceDiscoveryAttribute, WinUITestTargetAttribute, STATestClassAttribute, DataRowAttribute, DataTestMethodAttribute, and UITestMethodAttribute. Review their inheritance usage and existing tests, then make the requested sealing or removal changes and verify the MSTest test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.