`ITestHostManager.AddTestSessionLifetimeHandle` should be `Add...Handler`
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1k
- Forks
- 312
- Avg merge
- 8h 30m
- Merged PRs (30d)
- 469
Description
I suppose this is just a typo, but shouldn't the name of `ITestHostManager.AddTestSessionLifetimeHandle` be `AddTestSessionLifetimeHandle*r*`?
Compared to methods like the following, the name `AddTestSessionLifetimeHandle` is inconsistent.
- `ITestHostManager.AddDataConsumer` for `IDataConsumer`
- `ITestHostControllersManager.AddProcessLifetimeHandler` for `ITestHostProcessLifetimeHandler`
- `ICommandLineManager.AddProvider` for `ICommandLineOptionsProvider`
It's merely a naming issue, so I am not currently facing any specific problems.
However, I am reporting this issue because it may cause confusion in reflection calls, automatic code generation, documentation, and other contexts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for ITestHostManager.AddTestSessionLifetimeHandle and inspect its interface declaration and references. Compare the related AddDataConsumer, AddProcessLifetimeHandler, and AddProvider methods named in the issue. Done means the method uses the Handler name consistently wherever the old symbol is referenced, including relevant documentation or generated/reflection-facing references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100