microsoft / microsoft/testfx

Raise the minimum Roslyn version for MSTest.Analyzers to 4.14

Open
#10,446 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/analyzers type/breaking-change
Dominant language
C#
Stars
1k
Forks
312
Avg merge
8h 30m
Merged PRs (30d)
469

Description

Raise `MicrosoftCodeAnalysisVersion` from 3.11.0 to 4.14.0 for MSTest.Analyzers and its code fixes during the next breaking-change release.

This intentionally raises the minimum supported analyzer host to Roslyn 4.14 (Visual Studio 2022 17.14 / .NET 9.0.3xx SDK or newer). Older hosts cannot load analyzer assemblies built against Roslyn 4.14 because Roslyn is supplied by the compiler host and excluded from the MSTest.Analyzers package.

Implementation should:

- update `MicrosoftCodeAnalysisVersion` and raise `MicrosoftCodeAnalysisVersionForTests` to at least 4.14;
- adopt the newer Roslyn APIs and nullable annotations where appropriate;
- remove compatibility code that exists only for the Roslyn 3.11 build floor;
- verify the packaged analyzers and code fixes load and run on the oldest host retained by the v5 support policy;
- document the new minimum Visual Studio / .NET SDK requirement.

Reference: dotnet/sdk#55525, which makes the equivalent minimum-host change for the out-of-band Microsoft.CodeAnalysis.NetAnalyzers package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MicrosoftCodeAnalysisVersion and MicrosoftCodeAnalysisVersionForTests in the MSTest.Analyzers build configuration, then inspect the analyzer and code-fix compatibility paths tied to Roslyn 3.11. Verify the packaged analyzers and code fixes on the oldest host retained by the v5 support policy, and update documentation with the Visual Studio 2022 17.14 / .NET 9.0.3xx minimum.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.