microsoft / microsoft/terraform-provider-msgraph

Use "map of string" for query_parameters

Open
#25 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
65
Forks
25
Avg merge
3d 10h
Merged PRs (30d)
6

Description

Hi! The current syntax for query_parameters uses a "map of list of string". I know it's the same in AzAPI but I'm wondering if there really is a reason to use this complex format, or if you could reconsider this for msgraph and use a simple map instead? I pretty much always forget the brackets :(

It's also confusing because headers uses "map of string".

# Current syntax
query_parameters = {
  "$select" = ["id,mailNickName"]
}

# Proposed syntax
query_parameters = {
  "$select" = "id,mailNickName"
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Search the provider for the query_parameters and headers schema, then inspect how query parameters are serialized and covered by tests. Done means the simpler map-of-string syntax is supported consistently without regressing existing Microsoft Graph requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, terraform
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.