microsoft / microsoft/terminal
Validate that VT adapter tests cover all mock possibilities
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
All of the various mock definitions don't seem to be in use. When I stood up the original parser years ago and wrote the mock, every mock was checked somehow. Over time, it probably decayed and the only thing left is that the mock has to be implemented to satisfy compilation of the interface.
Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/891/review_comment/create
The goal here would be to run through all the tests and ensure that the mocks are involved somehow in each operation to validate that we're getting what we expect back through the adapter interface for all potential results.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the VT adapter tests and their mock definitions, then review which mock operations each test exercises. Ensure the tests cover the possible results returned through the adapter interface and verify that the complete test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100