microsoft / microsoft/terminal
adjust associative containers to support heterogeneous lookup
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Heterogeneous lookup has been supported since C++14. To quote the linked article,
C++14 allows the lookup to be done via an arbitrary type, so long as the comparison operator can compare that type with the actual key type. This would allow a map from
std::stringto some value to compare against aconst char*or any other type for which anoperator<overload is available. It is also useful for indexing composite objects in astd::setby the value of a single member without forcing the user offindto create a dummy object (for example creating an entirestruct Personto find a person by name).
Now, it's magic in that you enable it by specifying std::less<> as the third template argument to an associative container; that is:
std::map<std::string, std::string > map1;
std::map<std::string, std::string, std::less<>> map2;
map2 supports heterogeneous lookup, whereas map1 does not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named in the issue. Start by locating the associative-container code and establish which containers are in scope; done means the relevant containers support heterogeneous lookup as described, with tests covering it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100