microsoft / microsoft/terminal
Make FontFace ComboBox editable
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
If it were an Editable ComboBox, that makes it the best of both worlds.
You could also present a text warning, if the FontName read from the JSON, does not match a font available to use.
_Originally posted by @mdtauk in https://github.com/microsoft/terminal/issues/9275#issuecomment-788341048_
In a world where #9275 merged, it would be nice to make the ComboBox editable. But we need some kind of validation system in place to do that. This issue tracks doing all of that work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FontFace ComboBox and the code that reads FontName from JSON. Review issue #9275 for the related merged work, then determine how editable input and warnings for unavailable fonts should be validated. Done means the ComboBox accepts typed font names and clearly warns when a JSON font is unavailable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100