microsoft / microsoft/terminal
Untie `_UpdateCommandsForPalette` and `_RefreshUIForSettingsReload`
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
```c++
// Make sure to _UpdateCommandsForPalette before
// _RefreshUIForSettingsReload. _UpdateCommandsForPalette will make
// sure the KeyChordText of Commands is updated, which needs to
```
Huh. Really. That's a weird dependency.
Please file a followup task to .. i dunno, make the settings model standalone or something? It seems like it still can't work without Page around :|
_Originally posted by @DHowett in https://github.com/microsoft/terminal/pull/9253#discussion_r581332862_
Contributor guide
Research direction
Start by reading the relationship between `_UpdateCommandsForPalette` and `_RefreshUIForSettingsReload`, then review the originating discussion in PR #9253. Define how the settings model can operate without the Page dependency and document the resulting standalone boundary as the completion criteria.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100