microsoft / microsoft/terminal

CommandPalette's keyboard accelerators not read properly sometimes

Open
#9,248 0 comments 0 reactions 0 assignees View on GitHub
Area-Accessibility Area-CmdPal Help Wanted Issue-Bug Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

# Environment

WT version: after #9234 merges

# Steps to reproduce

1. open command palette
2. Navigate focus to a command with ctrl+- keyboard accelerator

# Expected behavior

screen reader reads "control minus"

# Actual behavior

screen reader reads "control plus"

# Suggested approach

https://docs.microsoft.com/en-us/windows/uwp/design/input/keyboard-accelerators

Maybe we need to create `KeyboardAccelerator` objects from the strings we get? This just sounds like the correct approach tbh.

Contributor guide

Open the contributing guide

Research direction

Start at the CommandPalette handling for keyboard accelerator strings, then review the Windows keyboard accelerator guidance linked in the issue. Reproduce the Ctrl-minus command with a screen reader and verify that it announces “control minus” rather than “control plus” after the accelerator handling is corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
accessibility, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.