microsoft / microsoft/terminal
Make all test binaries consistent in Target and Project name
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Probably another area where cleanup/reconciliation is needed.
The Host Unit Tests (the O.G. of our testing libraries) says
<ProjectName>Host.Tests.Unit</ProjectName>
<TargetName>Conhost.Unit.Tests</TargetName>
So at least the target name might need to be pluralized to match the pattern in the CI (i.e. Types.Unit.Tests).
I think ProjectName only affects the sort order inside Visual Studio so similar projects are sorted together visually.
I'd recommend aligning at least the TargetName (or confirming the CI pattern isn't looking for the plural) here and then filing a follow on task to make the test libraries named more consistently.
Originally posted by @miniksa in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMTc1MTU5OTM4OnYy/pull_request_review_threads/discussion
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Host Unit Tests and the other test project definitions, then compare their ProjectName and TargetName values with the naming pattern used in CI, especially Types.Unit.Tests. Confirm which names affect Visual Studio sorting versus CI matching; done means the relevant test binaries follow the agreed consistent naming pattern.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100