microsoft / microsoft/terminal
WM_NCHITTEST returns HTCAPTION for client area and tabs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Description of the new feature/enhancement
Please consider placing the tabs into the client area instead of the title bar. Right now the tabs are in the correct place only with setting "showTabsInTitlebar": false,. This will cause problems with softwares that utilize the title bars.
Default settings
"showTabsInTitlebar": false,
Proposed technical implementation details (optional)
Take a look at Edge browser. Edge used to place everything in the title bar as well, but now it has been fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Windows title-bar hit testing around WM_NCHITTEST and the showTabsInTitlebar setting. Compare the current default behavior with the false setting and the Edge example; done means tabs occupy the client area without returning HTCAPTION for client-area and tab interactions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100