microsoft / microsoft/terminal

Doesn't detect pwsh installed in custom directory from Scoop

Open
#8,264 7 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Settings good first issue Help Wanted In-PR Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

Environment

Windows build number: 10.0.19042.0
Windows Terminal version (if applicable): 1.4.3141.0

PowerShell Core: 7.1.0
Scoop

Steps to reproduce

  1. Installing Scoop to Custom Directory
  2. Install PowerShell Core via Scoop
  3. Open Windows Terminal

Expected behavior

When environment variable SCOOP or SCOOP_GLOBAL is defined, Terminal should search pwsh.exe in %SCOOP% and %SCOOP_GLOBAL% in addition to %USERPROFILE%\scoop.

Actual behavior

Error dialog is opened.
The content of error message is "An error occurred while loading the settings."
(Sorry, I don't know the message of English version because I use Japanese version).

And, PowerShell is used instead, and PowerShell Core doesn't appear in the shell list.

Searching place is only %USERPROFILE%scoop for Scoop.
(ref: PowershellCoreProfileGenerator.cpp Line 281, Tag 1.4.3141.0)

Related issue

#1415

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/cascadia/TerminalApp/PowershellCoreProfileGenerator.cpp at line 281 in the v1.4.3141.0 reference, then review related issue #1415. Reproduce the issue with Scoop installed in a custom directory and the SCOOP or SCOOP_GLOBAL variable defined; done means pwsh.exe is found there, the settings load without the error dialog, and PowerShell Core appears in the shell list.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.