microsoft / microsoft/terminal
ReadPendingInput plays unsafe byte/char games with pending data
Open
@adiviness is already working on this.
Since May 14, 2019.
Area-Input
Area-Server
Issue-Feature
Product-Conhost
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Ported from MSFT: 18047766.
I fixed an immediate crash bug in MSFT: 17987369 that affected this area, but realized at the time that it's really bad that the ReadPendingInput function in the console host is playing games with a void pointer and mix-and-match of byte versus character counting.
This represents investigating what we can do to stop mix/matching the char and byte counts in ReadPendingInput.
@adiviness might be working on something like this with his changes to input to support emoji...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.