microsoft / microsoft/terminal
LVB Gridlines do not transit ConPTY (Win32 "underline", overline, left/right)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Windows 10, Windows Terminal, Version: 1.3.2651.0
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):
Any other software?
I use
-- SetConsoleMode(hStdin, ENABLE_WINDOW_INPUT | ENABLE_LVB_GRID_WORLDWIDE )
-- I do "| COMMON_LVB_UNDERSCORE' on the attributes of CHAR_INFO 'line'
-- WriteConsoleOutput(... line );
I am 95% sure the rest of the code is valid -- because I can do colors, etc.
Expected behavior
-- characters should be underlined.
Actual behavior
-- no underline
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported sequence using SetConsoleMode, COMMON_LVB_UNDERSCORE, and WriteConsoleOutput through ConPTY. Compare the handling of underline, overline, and left/right gridline attributes, then verify that the corresponding characters render with those attributes in Windows Terminal.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100