microsoft / microsoft/terminal
Add Optional Cursor Properties to Color Schemes
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
There are several fields assigned against profiles that feel like they would be better placed in schemes (or at least duplicated to schemes):
cursorColorcursorShapefontFacefontSize
There are two options for these properties that could be utilised:
- Remove them from the profile and add them to schemes, updating the current schemes with default values.
- Leave them in the profile and have them act as an override when present, similar to what
backgroundis doing currently.
Additionally, it may be worth actually removing the default background value, to allow the theme background to actually work by default.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how profile and scheme properties are represented, including the existing background override behavior. The issue leaves two implementation approaches open; done requires a decided treatment for cursorColor, cursorShape, fontFace, fontSize, and the default background behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100