microsoft / microsoft/terminal
Investigate using ZWNJ at the beginning of COOKED_READ_DATA line
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
This is a follow on from #514.
We could potentially insert a ZWNJ at the beginning of a cooked read data line to prevent ligature joins from happening between the immutable text and the prompt line for applications that use the cooked read data services of the conhost.exe. This would make this work automagically for cmd.exe and a bunch of little utilities.
There are some concerns about sending that through ConPTY that I think are justified (as would be required to make this work in any fashion on the Windows Terminal UI).
Either way, this is going to need someone to fool around with it and see what works and what doesn't.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the context from issue #514 and the behavior of cooked read data in conhost.exe. Experiment with inserting a ZWNJ at the beginning of a cooked read data line, checking ligature behavior for cmd.exe and other utilities, and whether sending it through ConPTY causes problems; done means the behavior and tradeoffs are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100