microsoft / microsoft/terminal
Move u8State from WriteConsoleAImpl to SCREEN_INFORMATION
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview
In #4493 @miniksa pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to
https://github.com/microsoft/terminal/pull/4493#discussion_r389024806
In the current code base it's still in WriteConsoleAImpl though.
https://github.com/microsoft/terminal/blob/d0ff5f6b5e7687c438e0a8b120280be307eda778/src/host/_stream.cpp#L1107
Since I closed the PR I just don't want this information to get lost.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/host/_stream.cpp at the WriteConsoleAImpl code linked in the issue, then read the referenced #4493 discussion about SCREEN_INFORMATION. Trace how u8State is declared and used, and confirm the change is complete when that state belongs to SCREEN_INFORMATION rather than WriteConsoleAImpl while the relevant console-host build or tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100