microsoft / microsoft/terminal

Parameterizable dynamic profiles

Open
#5,571 4 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Commandline Area-Settings Issue-Feature Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

Description of the new feature/enhancement

Eventually the plugin system will allow to contribute new dynamic profiles. I think it would be useful if there was a way to parameterize dynamic profiles. Currently, the automatically provided "commandline" has to be overridden to customize anything. I think this breaks abstraction/layering/encapsulation/... and often there would be no need for it if dynamic profile providers become smarter. See examples below. If the community can't come up with more use cases then it's not worth the effort obviously. This issue is about collecting ideas and opinions.

Proposed technical implementation details (optional)

Instead of:

            {
                "guid": "{f9679c4b-7da6-409d-a372-86ebe9127f2a}",
                "commandline" : "powershell.exe -ExecutionPolicy ByPass -NoExit -Command \"& '%USERPROFILE%\\Miniconda3\\shell\\condabin\\conda-hook.ps1' ; conda activate tensorflow\"",
                "icon" : "%USERPROFILE%/Miniconda3/Menu/Iconleak-Atrous-PSConsole.ico",
                "name" : "Miniconda (tensorflow)"
            }

I'd like:

            {
                "guid": "{f9679c4b-7da6-409d-a372-86ebe9127f2a}",
                "source": "Continuum.Miniconda3",
                "name" : "Miniconda (tensorflow)",
                "options": {
                  "env": "tensorflow", // defaults to "base"
                  "shell": "powershell" // or "cmd"
                }
            }

Instead of:

            {
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "source": "Windows.Terminal.PowershellCore",
                "commandline": "C:\\Program Files\\PowerShell\\6\\pwsh.exe --NoLogo"  
            }

I'd like:

            {
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "source": "Windows.Terminal.PowershellCore",
                "options": {
                  "nologo": true
                }
            }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are identified. Start by reviewing the dynamic profile/plugin system and the existing commandline and source configuration examples; define the supported parameter model, use cases, and acceptance criteria before implementation.

Written by the indexing model from the issue text.

Assessment

Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.