microsoft / microsoft/terminal
Remove usages of old safe math
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
There are approximately 79 uses of old safe math. (a.k.a. the LongAdd, ShortAdd, and friends from intsafe.h).
This task represents removing them and transitioning them to an appropriate safe/saturating math function from the chromium safe math library introduced in #4144.
After removing usages of the old safe math functions, also remove the intsafe.h header.
Files with old safe math as of this writing:
- TerminalControl: TSFInputControl.cpp
- TerminalCore: TerminalDispatch.cpp
- TerminalCore: TerminalSelection.cpp
- Host: directio.cpp
- RendererGdi: invalidate.cpp
- RendererGdi: math.cpp
- RendererGdi: paint.cpp
- RendererVt: paint.cpp
- TerminalAdapter: adaptDispatch.cpp
- Types: viewport.cpp
- Types: WindowUiaProviderBase.cpp
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Chromium safe math library introduced in #4144, then inspect the listed usages in TSFInputControl.cpp, TerminalDispatch.cpp, TerminalSelection.cpp, directio.cpp, the RendererGdi and RendererVt files, adaptDispatch.cpp, viewport.cpp, and WindowUiaProviderBase.cpp. Done means all old LongAdd, ShortAdd, and related usages are transitioned appropriately and the intsafe.h header is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100