microsoft / microsoft/terminal
Code Health: Update existing winrt properties to use `GETSET_PROPERTY` when possible
Open
Nobody has claimed this yet.
Area-CodeHealth
Help Wanted
Issue-Task
Product-Terminal
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Pretty self explanatory. Classes with a bunch of
uint32_t TerminalSettings::DefaultForeground()
{
return _defaultForeground;
}
void TerminalSettings::DefaultForeground(uint32_t value)
{
_defaultForeground = value;
}
Is an enormous amount of boilerplate we don't need.
GETSET_PROPERTY(uint32_t, DefaultForeground, DEFAULT_FOREGROUND_WITH_ALPHA);
is better.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the C++ classes that define WinRT properties using paired getter and setter methods, then compare them with the existing GETSET_PROPERTY macro pattern shown in the issue. Replace only properties where the macro is applicable, preserving behavior; done means eligible boilerplate is removed without changing property access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100