microsoft / microsoft/terminal
Make the feature tests run in (and perhaps explode) a PTY
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
#3907 causes a crash when connected to a pseudoconsole; @miniksa suggested that we should make sure we're running our API tests against ptys as well.
zadjii-msft EDIT: Let's be really sure that when we're making the feature tests run in conpty mode, we add a test to check #3907. The fix in #4021 is pretty small, whoever gets to this task should try reverting it and make sure that an appropriate test is added.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the feature or API tests and the conpty/PTY test setup referenced in the issue, then review #3907 and the small fix in #4021. Done means the feature tests run in conpty mode and include a regression test that exposes the #3907 crash when #4021 is reverted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100