microsoft / microsoft/terminal
Move shader files to `hlsl` files and package as a part of app
Open
Nobody has claimed this yet.
Area-Rendering
Issue-Task
Product-Terminal
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Follow-up from #3468.
Right now we're just packaging them in the renderer itself, as string literals. As great as that is, we should probably make them their own files.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with issue #3468 and the renderer code that currently packages shaders as string literals; identify the existing shader contents and packaging path. Done means the shaders are separate HLSL files and are packaged as part of the app.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, computer-graphics
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100