microsoft / microsoft/terminal
Hebrew char taf ת (accessible by comma key on hebrew keyboard) appears in settings
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
A quick note:
First off, loving v. 0.7. Secondly, this is a ridiculously minor bug that I haven't been able to even reproduce on my own machine. Don't really bother fixing it, I guess. But it's still undefined behavior, and I thought you might want to know that something like this can happen.
Environment
Windows: Microsoft Windows [Version 10.0.18362.476]
Windows Terminal version (if applicable): 0.7.3291.0
Any other software?
Steps to reproduce
Not sure, haven't been able to reproduce it myself.
Expected behavior
Should be Ctrl+comma displayed, IIRC.
Actual behavior
A quick note: the character here, the hebrew letter taf - ת, is comma on the hebrew keyboard
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the settings shortcut display with a Hebrew keyboard and compare the rendered key with the expected Ctrl+comma; done means the shortcut is displayed correctly in that environment and the behavior is covered by an appropriate check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100