microsoft / microsoft/terminal

iTerm color schemes once more are failing to parse colors

Open
#352 11 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Settings Help Wanted Issue-Bug Product-Colortool Work-Item
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

Not sure if I am supposed to request to get this re-opened or if I should create another bug. But this is the same as in #2

  • Your Windows build number: (Type ver at a Windows Command Prompt)
    Microsoft Windows [Version 10.0.17763.253]

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
    Running:
    PS C:\Tools\ColorTool> .\ColorTool.exe C:\Tools\ColorTool/schemes/molokai.itermcolors
    Error loading ini file "C:\Tools\ColorTool/schemes/molokai.itermcolors"
    for key "DARK_BLACK"
    the value "" is invalid

The actual file contents can be found in this gist:
https://gist.github.com/SneWs/4bbb50dce9a132a4dcbd07e3e2c85c44

  • What's wrong / what should be happening instead:
    The colors should be successfully parsed and set without any error messages being rendered.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ColorTool.exe command and the molokai.itermcolors file linked in the issue, then trace how the iTerm color scheme is parsed, especially the DARK_BLACK key and its empty value. Reproduce the error on the reported Windows version and confirm that the scheme parses and applies without an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.