microsoft / microsoft/terminal
Add a setting to manually set the Pane border width
Open
Nobody has claimed this yet.
Area-Settings
Area-UserInterface
Help Wanted
Issue-Task
Product-Terminal
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Follow up from #994 and PR:#3060
In the aforementioned PR, we're hardcoding the border width to 2. This should really be configurable to any positive double.
Questions:
- (Similar to the discussion in #3061) There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this?
- If we do want to do this in XAML later, would enabling it in the json now negatively impact that future scenario?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #3060 and the discussion in issues #994 and #3061, since this issue does not name implementation files or tests. Determine whether the setting belongs in JSON configuration or should wait for the proposed XAML theming work. Done means supporting any positive double value for the Pane border width with an agreed configuration path and validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100