microsoft / microsoft/terminal
Figure out what to do with keybindings whose characters could be triggered by multiple VKs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
I tried to map ctrl+shift+| for vertical split but keybinding changed to \(but everything works correctly) additionally i have second backslash button between left shift and z key and using this key combination doesn't work.
Environment
Windows build number: 10.0.18963.0
Windows Terminal version (if applicable): 0.3.2171.0
Keyboard: Logitech K280e
Steps to reproduce
- Add binding:
{ "command" : "splitVertical", "keys" : [ "ctrl+shift+|" ] }, - Save and close settings
- Close Terminal
- Open Terminal and settings
- Binding looks like this:
{ "command" : "splitVertical", "keys" : [ "ctrl+shift+\\" ] },
No matter what during this steps left backslash never works.
Expected behavior
Keep original symbol and accept left backslash key as trigger.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the keybinding behavior using the settings entry and the Windows keyboard described in the issue, then trace how the binding is parsed, saved, and mapped to virtual keys. Done means the original ctrl+shift+| symbol is preserved and the left backslash key can trigger the binding without breaking existing keybindings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100