microsoft / microsoft/terminal
Implement a helper function either in terminal or the textbuffer that allows easy movement of text from 1 location to another
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
DeleteCharacter and InsertCharacter both require moving text while retaining their text attributes. The logic used to do that movement should be put into a separate helper function so that other operations can make use of it as well.
Originally posted by @PankajBhojwani in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMTg5NzIxMjU3OnYy/pull_request_review_threads/discussion
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DeleteCharacter and InsertCharacter in the terminal or textbuffer code and compare the logic they use to move text while retaining attributes. Extract that shared movement logic into a helper that both operations can use, then verify the existing behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100