microsoft / microsoft/terminal
Make BeginResize a RAII thing
Open
Nobody has claimed this yet.
Area-CodeHealth
Issue-Task
Product-Conhost
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Uh, maybe this method should just return an RAII object that stops the resize when it is destroyed like what we envision good locks to do.
Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/2149
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the BeginResize implementation and the discussion in pull request 2149, which is referenced in the issue. Determine how resize stopping currently works and define the RAII lifetime behavior; done means the returned object reliably stops resizing when it is destroyed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100