microsoft / microsoft/terminal

Link hover/click regions are calculated incorrectly on double-width lines

Open
#20,174 3 comments 0 reactions 0 assignees View on GitHub
Area-TerminalControl Impact-Visual Issue-Bug Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.25.622.0

### Windows build number

10.0.19045.5371

### Other Software

_No response_

### Steps to reproduce

Execute the following command in a WSL bash shell:
```sh
echo -e "\e#6This is a \e]8;;http://example.org\e\\link\e]8;;\e\\ test"
```
Then hover the mouse cursor of the word `link`.

### Expected Behavior

The dotted underline of the link should change to a solid underline, and a tooltip should appear showing the link destination.

### Actual Behavior

Nothing happens when you hover over `link`. You instead need to hover over the word `is` in order for the link to be detected. It seems that the link region calculation in not taking line attributes into account.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in Windows Terminal 1.25.622.0 using the provided WSL bash command, then inspect the link hover and click-region calculation where line attributes are handled. Done means hovering directly over “link” changes its underline and shows the http://example.org destination tooltip.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.