microsoft / microsoft/terminal
conhost-1.25: block selection no longer strips whitespace from the right
Open
Nobody has claimed this yet.
Issue-Bug
Priority-3
Product-Conhost
zInbox-Bug
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
The last build of conhost contained #9087, so it may have regressed with #16377, which changed how copies worked (and how trimming was propagated into the copy request); there is also a chance I regressed it with #17638
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the behavior changes in #9087, #16377, and #17638, focusing on conhost block-selection copy handling and whitespace trimming. Reproduce the regression in conhost-1.25 and trace the copy request path; done means block selections once again strip trailing whitespace from the right.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100