microsoft / microsoft/terminal

Allow the "Close window" keyboard shortcut to also confirm closing the window when there are multiple tabs open

Open
#20,062 6 comments 1 reaction 0 assignees View on GitHub
Area-UserInterface Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Description of the new feature

This, of course, only applies if the "Warn when closing more than one tab" setting is active.
It would make pressing the "Close window" keyboard shortcut behave like clicking the window close button already does: click once to close window, if there's a confirmation dialog because there are multiple tabs opened, click again to confirm. It would be faster and more ergonomical than having to reach for "Enter", especially if the other hand is on the mouse.

### Proposed technical implementation details

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by tracing the "Close window" keyboard shortcut and comparing it with the existing window close-button behavior. Check how the "Warn when closing more than one tab" setting triggers confirmation. Done means invoking the shortcut again confirms the close when the dialog is shown, matching the close-button flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.