microsoft / microsoft/terminal
Make sure MinMaxCloseControl supports FullScreen & Tablet Mode
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Some thoughts about the Min/Max/Close buttons, and supporting FullScreen or Tablet Mode
Some properties to consider for this TitlebarControl. This could be also be useful for the Settings UI, if it is presented in a window.
- CanMaximise
- CanMinimise
- CanRestore
Which would hide those buttons if you wanted to make a settings screen which only shows a close button. Also consider how these TitleBar Controls will handle FullScreen/Tablet Mode
Full Screen
Tablet Mode
Originally posted by @mdtauk in https://github.com/microsoft/terminal/pull/1948#issuecomment-512048300
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MinMaxCloseControl and related TitlebarControl implementation; the issue names no files or tests. Determine how the controls should expose CanMaximise, CanMinimise, and CanRestore, and how fullscreen and tablet mode should affect them; done means the requested title-bar behavior is supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100