microsoft / microsoft/terminal
initialRows/initialCols should respect the first launched profile in a window, rather than the default
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Current behavior
Currently, the `--size` command uses the font of the default profile to calculate window size, which results in a different size when opening another profile with a different font setting.
### Proposed change
Add a new `Default launch size` field to profile settings. If only one profile is requested at launch, use the size from the new field (`--size` overrides it) with the font settings of the specified profile. If multiple profiles is requested, use the current behavior.
### Why do I need this feature
This is important for my workflow as I need to open an instance with many small cells instead of a few big cells. Changing from the settings page is slow and ruins the default settings.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the --size command calculates dimensions and how profile settings are loaded. Compare launches with one requested profile against launches with multiple profiles, then verify that the new Default launch size is used only for the single-profile case and that --size still takes precedence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100